More test fixes #4235
Merged
More test fixes #4235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
approved these changes
May 8, 2017
| Assert that the log file contains no ERR or WARN lines. | ||
| """ | ||
| log = self.get_log() | ||
| log = log.replace("WARN EXPERIMENTAL", "") |
|
Let me fix it up to get it back to the three separate commits. Then you can use "rebase and merge". |
The thrift test config used double quotes around Windows path separators and this was interpreted incorrectly in YAML parsing.
And in system tests, centralize the logic for asserting that there are no ERR or WARN in logs. Filter out errors about “The service process could not connect to the service controller” that occur when testing on Jenkins where Jenkins itself is running as a service. This confuses the Beat because it thinks that it is running as service, but it’s not.
This test doesn’t actually test any bad conditions. Plus there is another test in the same directory with the name TestBadCondition.
andrewkroh
force-pushed
the
bugfix/windows-tests
branch
from
b22f00c to
ab84099
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to #4216 to fix some more tests on Windows.
These are the failures being addressed (except the Filebeat ones, those need specialized attention): https://beats-ci.elastic.co/job/elastic+beats+master+tests-windows/4/testReport/
Using single quotes around Windows paths e86d38b
The thrift test config used double quotes around Windows path separators and this was interpreted incorrectly in YAML parsing.
Use logp.Beta or logp.Experimental in metricsets 077d508
And in system tests, centralize the logic for asserting that there are no ERR or WARN in logs.
Filter out errors about “The service process could not connect to the service controller” that occur when testing on Jenkins where Jenkins itself is running as a service. This confuses the Beat because it thinks that it is running as service, but it’s not.
Rename TestBadCondition to TestConditions ab84099
This test doesn’t actually test any bad conditions. Plus there is another test in the same directory with the name TestBadCondition.